restrict output size in Shelley-MA #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
reviewed
Jan 14, 2021
| filter | ||
| ( \out -> | ||
| let v = getField @"value" out | ||
| in Val.size v > 10000 |
There was a problem hiding this comment.
Since this also applies in Allegra, we need to validate against the current chain
There was a problem hiding this comment.
yes indeed!
for Coin, size is always 1, but of course we should still validate.
There was a problem hiding this comment.
Oh, that's a good point! We're probably fine then :-)
Having multi-asset output value sizes bounded only by what can fit into a transaction within the transaction size limit can make things awkward. The hypothetical example is that someone sends a near-max size utxo to someone else. This output is now difficult to spend. It cannot be spent simultaneously with any other input or any other output since it so near the limit. One might not be able to split it into two UTxOs since two smaller ones is probably bigger than one big one. At worst this output is stuck, at best it is annoying.
JaredCorduan
force-pushed
the
jc/restrict-shelley-ma-ouput-size
branch
from
8cf0626 to
aec21cb
Compare
nc6
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having multi-asset output value sizes bounded only by what can fit into a
transaction within the transaction size limit can make things awkward.
The hypothetical example is that someone sends a near-max size utxo to
someone else. This output is now difficult to spend.
It cannot be spent simultaneously with any other input or any other output
since it so near the limit. One might not be able to split it into two UTxOs
since two smaller ones is probably bigger than one big one.
At worst this output is stuck, at best it is annoying.