Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FakePlutus and intgegrate Real Plutus #2242

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Conversation

TimSheard
Copy link
Contributor

Integrate the new additions of Plutus that use the updated notion of a TxInfo and ScriptContext.

This allows us to remove the module FakePlutus which contained a bunch of stubs.
One last issue to resolve is the translation of CostModels which will be in another PR.

@TimSheard TimSheard assigned nc6 and unassigned nc6 Apr 19, 2021
@TimSheard TimSheard requested a review from nc6 April 19, 2021 17:36
import qualified Language.PlutusCore.Evaluation.Machine.ExMemory as P (ExCPU (..), ExMemory (..))
import qualified Language.PlutusTx as P (Data (..))
import qualified Language.PlutusTx.IsData.Class as P (IsData (..))
-- Import Plutus stuff in the qualified Module P
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transCostModel :: CostModel -> P.CostModelParameters
transCostModel (CostModel mp) = Map.foldlWithKey' (\ans bytes n -> Map.insert (show bytes) n ans) Map.empty mp
transCostModel :: CostModel -> P.CostModel
transCostModel (CostModel _mp) = undefined -- Map.foldlWithKey' (\ans bytes n -> Map.insert (show bytes) n ans) Map.empty mp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, IMHO, since figuring out where best to validate the cost model is next up on our agenda.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment that can be deleted aside, looks great!

@JaredCorduan JaredCorduan merged commit 9a00f17 into master Apr 19, 2021
@iohk-bors iohk-bors bot deleted the upgrade-plutus branch April 19, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants