BBODY examples #2259
Merged
BBODY examples #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/bbody-examples
branch
from
87d3131
to
4cb281f
Compare
TimSheard
approved these changes
May 5, 2021
Comment on lines
87
to
90
|
|
||
| initBBodyState :: BbodyState A | ||
| initBBodyState = BbodyState (LedgerState UTXOW.initUtxoSt dpstate) (BlocksMade mempty) | ||
|
|
There was a problem hiding this comment.
call this initialBBodyState, initBBody state sounds like a noun, so I expect it to be a function.
Comment on lines
100
to
116
| BHBody | ||
| { bheaderBlockNo = BlockNo 0, | ||
| bheaderSlotNo = SlotNo 0, | ||
| bheaderPrev = GenesisHash, | ||
| bheaderVk = vKey coldKeys, | ||
| bheaderVrfVk = vvrf, | ||
| bheaderEta = coerce $ evalCertified () nonceNonce svrf, | ||
| bheaderL = coerce $ evalCertified () leaderNonce svrf, | ||
| bsize = fromIntegral $ bBodySize txs, | ||
| bhash = hashTxSeq txs, | ||
| bheaderOCert = | ||
| OCert | ||
| vkes | ||
| 0 | ||
| (KESPeriod 0) | ||
| (signedDSIGN @C_Crypto (sKey coldKeys) (OCertSignable vkes 0 (KESPeriod 0))), | ||
| bprotver = ProtVer 5 0 |
There was a problem hiding this comment.
Should this part, making the BHBody be a function that is reusable? Seems it is a function of txs.
Comment on lines
168
to
174
|
|
||
| -- | We always expect the alwaysFailsOutput to remain in the UTxO map. | ||
| -- Each of the eight example transactions below will consume one of the | ||
| -- feeInputs, given by feeInputs. | ||
| -- The transaction where IsValidating is True will create a transaction output. | ||
| -- Additionally, the alwaysFailsOutput will be consumed in the IsSpend case. | ||
| expectedUTxO :: Expect -> Natural -> UTxO A |
There was a problem hiding this comment.
Add to the comments how this should be used. The comments tells what it does, not how one should use it.
added 3 commits
May 5, 2021 10:57
The function was replaced by collectTwoPhaseScriptInputs a while ago, but the old function was never removed.
JaredCorduan
force-pushed
the
jc/bbody-examples
branch
from
4cb281f
to
485d7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes an
BBODYexample by packing the 8 transactions from theUTXOWexamples into a single block. This is the top-most rule changed in the Alonzo era.This involved a bit of reorganizing the UTXOW examples.
Additionally, I changed the
collectTwoPhaseScriptInputsfunction to supply Plutus data in this order: datum, redeemer, context. See #2248 (comment).I also removed the unused function
collectNNScriptInputswhich was previously replaced bycollectTwoPhaseScriptInputs.