Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event logger redux #2373

Merged
merged 8 commits into from
Jul 19, 2021
Merged

Event logger redux #2373

merged 8 commits into from
Jul 19, 2021

Conversation

goolord
Copy link
Contributor

@goolord goolord commented Jul 8, 2021

  • adds back the event logger as an associated type family. will figure out how to make it easier to case on all of the events later. the best solution is most likely to be maintaining an event product type with the constructors for every event
  • adds stake pool initial registration event
  • adds stake pool re-registration event
  • adds sum of the deposits in a transaction event

previous prs with relevant discussion
#2244
#2356

@nc6 nc6 self-requested a review July 12, 2021 14:56
Copy link
Contributor

@nc6 nc6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. A few comments in some areas.

@goolord goolord merged commit fe48eee into master Jul 19, 2021
@iohk-bors iohk-bors bot deleted the event-logger-redux branch July 19, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants