Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cardano-base and derive Measure for ExUnits #2391

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Jul 21, 2021

cardano-base now defines the Measure class and the Consensus Layer needs ExUnits to instantiate it. This PR does so.

@nfrisby nfrisby added the 🤝 consensus Tickets that the fine folks over at ouroboros-consensus want to keep track of label Jul 21, 2021
@nfrisby nfrisby requested a review from nc6 July 21, 2021 23:58
@nfrisby nfrisby force-pushed the nfrisby/exunits-measure-instances branch from bdbabd6 to 421302f Compare July 22, 2021 00:02
via (InstantiatedAt Generic ExUnits)
deriving
(Monoid, Semigroup)
via (InstantiatedAt Measure ExUnits)
Copy link
Contributor

@nc6 nc6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nc6 nc6 merged commit 46ca4ed into master Jul 22, 2021
@iohk-bors iohk-bors bot deleted the nfrisby/exunits-measure-instances branch July 22, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤝 consensus Tickets that the fine folks over at ouroboros-consensus want to keep track of
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants