Improve tx out compacting #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Case Max MaxOS Live Allocated GCs Wall Time IntMap (KeyMap TxId TxOut) (original) 1,185,790,008 3,191,865,344 1,194,345,304 199,779,514,568 176,472 398.977s IntMap (KeyMap TxId TxOut) 1,185,789,440 3,132,096,512 1,194,344,248 174,999,006,728 163,813 366.926s IntMap (KeyMap TxId TxOut) (sharing) 1,063,937,144 2,557,476,864 1,072,490,464 180,082,957,552 168,734 356.143s IntMap (KeyMap TxId TxOut') 1,163,115,976 3,128,950,784 1,171,668,776 182,641,648,320 171,162 337.480s IntMap (KeyMap TxId TxOut') (sharing) 1,041,263,648 2,487,222,272 1,049,814,984 189,083,461,088 177,386 334.723s ```
JaredCorduan
approved these changes
Nov 16, 2021
nc6
reviewed
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation I found out why we didn't get as much as expected on the compacting
TxOut. It turns out constraints on data types do not come for free. Dropping those constraints in favor of couple impossible error calls we regain the expected savings on the TxOut:Legend:
TxOut'is what implemented in this PRTxOutis what we have on masteroriginalwhat was there before Create a more compact TxOut using unpacked Word64s #2534Only this commit is important in this PR: 3da6065 the rest are changes to the benchmarking tool that were needed for getting this problem figured out.