Move ApplyTx benchmarks to using a fixed seed. #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
force-pushed
the
nc/bench-rewrite
branch
2 times, most recently
from
e46210e
to
1f2748e
Compare
This should prevent problems where serialisation changes result in broken benchmarks. Additionally, we now test Allegra and Mary era transactions. Unfortunately this means a discontinuity with existing benchmark runs, but should prevent future discontinuities.
lehins
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
I have one comment about benchmarks, which hasn't been touched by this PR, but it is important:
applyTxsTransition returns a tuple, which means it is not enough to evaluate it to whnf, it has to be nf in this benchmark:
If NFData instance is a problem at least replacing id with
\(x, y) -> x `seq` y `seq` (x, y)would be a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent problems where serialisation changes result in
broken benchmarks. Additionally, we now test Allegra and Mary era
transactions.
Unfortunately this means a discontinuity with existing benchmark runs,
but should prevent future discontinuities.