-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drep registration expiration fix #4547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
reviewed
Aug 13, 2024
lehins
reviewed
Aug 13, 2024
teodanciu
force-pushed
the
td/drep-registration-expiration-fix
branch
3 times, most recently
from
August 14, 2024 13:41
ed500c0
to
f3e6c09
Compare
aniketd
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice catch and investigation!
lehins
reviewed
Aug 14, 2024
teodanciu
force-pushed
the
td/drep-registration-expiration-fix
branch
2 times, most recently
from
August 16, 2024 11:28
417f7b7
to
358575d
Compare
for more flexible use
to subtract the added number of dormant epochs from the total
teodanciu
force-pushed
the
td/drep-registration-expiration-fix
branch
from
August 16, 2024 11:29
358575d
to
f668f36
Compare
lehins
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you for finding and fixing this issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Registering a drep at a time when there were dormant epochs results in the drep expiry to be set greater than expected (ppDrepActivity + currentEpoch + vsNumDormantEpochs).
This PR changes this value, by setting the expiration using the same calculation as for UpdateDrep signal, namely: ppDrepActivity + currentEpoch - vsNumDormantEpochs, since the latter value is going to be added to the computation by CERTS,if there are proposals in the transaction.
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)