Fix deserialization of bad Ptrs in IncrementalStake
#4589
Merged
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2024
Merged
lehins
force-pushed
the
lehins/fix-deserialization-of-bad-ptrs-in-incrementalstakedistr
branch
from
1e20125
to
89560ac
Compare
lehins
force-pushed
the
lehins/fix-deserialization-of-bad-ptrs-in-incrementalstakedistr
branch
from
89560ac
to
7cb30c2
Compare
Tomorrow we are going into Conway, so this Map will no longer be useful as soon as we clean up the Ptr resolution. If we generate Ptr map in IncrementalStake we will run into issues with roundtripping serialization for Conway. So the easiest path forward is to disable generation now and completely get rid of the field later.
disassembler
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
Approving based on @amesgen testing earlier today pending CI roundtrip failures are addressed first.
lehins
deleted the
lehins/fix-deserialization-of-bad-ptrs-in-incrementalstakedistr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)