-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GovRemovedVotes event #4661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good first attempt, but there are a couple of things I don't quite like about it:
- It makes the addition of votes quite a bit more complicated, which is a dangerous thing and could lead to bugs in the future. At the very least it makes the logic for addition of votes so much harder to read
- It could affect performance of addition of votes, due to a more complex accumulator and some extra indirections
There is a better way to tackle this and we already have a very similar logic for figuring out known voters, which could be used for this purpose as well. I was not sure how to exactly suggest it, so I've just implemented it in this commit, so feel free to steal into your PR: 87e9c94
d1623c8
to
ba782e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
741bca4
to
9399e3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this breaking change didn't make it into the latest 1.17.0.0 release, so we need to bump it to 1.18.0.0
3bea797
to
2420477
Compare
2420477
to
bf7a978
Compare
bf7a978
to
2864130
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thank you!
Description
An attempt for #4633.
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)