Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/cardano ledger conway 1.17.2.0 #4716

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Release/cardano ledger conway 1.17.2.0 #4716

merged 3 commits into from
Oct 23, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Oct 23, 2024 •
edited
Loading

Description

Backport release of #4715

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

lehins added 2 commits October 23, 2024 14:16
@lehins
Adjust semantics of ConwayWdrlNotDelegatedToDRep
412d610 
Previous semantics did not allow to withdraw rewards and deregister in
the same transaction, because deregistration would effectively clear
out delegation to a DRep, thus preventing withdrawals
@lehins
Add a test case for recent changeof ConwayWdrlNotDelegatedToDRep sema…
d4f0d1b 
…ntics: #4715
@lehins lehins requested a review from a team as a code owner October 23, 2024 20:19
@lehins lehins mentioned this pull request Oct 23, 2024
Merged
@lehins lehins merged commit 9aafb58 into release/cardano-ledger-conway-1.17.1.0 Oct 23, 2024
25 of 29 checks passed
@lehins lehins deleted the release/cardano-ledger-conway-1.17.2.0 branch October 23, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lehins