Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] - Allow docker container configuration through env vars #2801

Closed
tdiesler opened this issue Jun 8, 2021 · 1 comment
Closed

[FR] - Allow docker container configuration through env vars #2801

tdiesler opened this issue Jun 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@tdiesler
Copy link
Contributor

tdiesler commented Jun 8, 2021

Internal/External
External

Area
Other Docker

Describe the feature you'd like

The standard way to configure docker containers is through env vars (rather than through cmd line args)
This allows higher order orchestration frameworks like docker compose, k8s to take advantage of a unified configuration mechanism.

Additional context / screenshots

For example the existing cardano-db-sync compose script would benefit from this
@tdiesler tdiesler added the enhancement New feature or request label Jun 8, 2021
@tdiesler tdiesler changed the title [FR] - All docker container to get configured through env vars [FR] - Allow docker container configuration through env vars Jun 8, 2021
tdiesler added a commit to tdiesler/cardano-node that referenced this issue Jun 8, 2021
@tdiesler
[IntersectMBO#2801] Allow docker container configuration through env …
11a446f 
…vars
tdiesler added a commit to tdiesler/cardano-node that referenced this issue Jun 9, 2021
@tdiesler
[IntersectMBO#2801] Allow docker container configuration through env …
e321767 
…vars
tdiesler added a commit to tdiesler/cardano-node that referenced this issue Jun 10, 2021
@tdiesler
[IntersectMBO#2801] Allow docker container configuration through env …
d9c8317 
…vars
iohk-bors bot added a commit that referenced this issue Jun 10, 2021
@iohk-bors @tdiesler
Merge #2812
1bff41c 
2812: [#2801] Allow docker container configuration through env vars r=jbgi a=tdiesler



Co-authored-by: Thomas Diesler <tdiesler@redhat.com>
@tdiesler
Copy link
Contributor Author

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdiesler