Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cardano Node TODOs 2020-11-12 #2103

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Cardano Node TODOs 2020-11-12 #2103

merged 2 commits into from
Dec 8, 2020

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Nov 18, 2020 •
edited
Loading

  • Add prettyPrintJSON function
  • Replace CardanoEra with ByronKeyFormat

@intricate
Copy link
Contributor

intricate commented Nov 18, 2020 •
edited
Loading

121120

What does this refer to?

edit: Oh, if that's the date, consider using the ISO 8601 representation, YYYY-MM-DD (2020-11-12), or YYYYMMDD (20201112).

@Jimbo4350 Jimbo4350 changed the title Cardano Node TODOs 121120 Cardano Node TODOs 2020-11-12 Nov 19, 2020
@Jimbo4350 Jimbo4350 force-pushed the jordan/cardano-node-todos-121120 branch from 759d3f7 to 17ed5c5 Compare December 7, 2020 09:08
dcoutts
dcoutts approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jimbo4350
Copy link
Contributor Author

bors merge

iohk-bors bot added a commit that referenced this pull request Dec 7, 2020
@iohk-bors @Jimbo4350
Merge #2103
e7512a7 
2103: Cardano Node TODOs 2020-11-12 r=Jimbo4350 a=Jimbo4350

- Add prettyPrintJSON function 
- Replace CardanoEra with ByronKeyFormat

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@dcoutts
Copy link
Contributor

dcoutts commented Dec 7, 2020

Lets hold off merging before 1.24.x is sorted out. It's not essential for that release.

@dcoutts
Copy link
Contributor

dcoutts commented Dec 7, 2020

bors cancel

@dcoutts
Copy link
Contributor

dcoutts commented Dec 7, 2020

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 7, 2020

Canceled.

@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 8, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit fefe4b5 into master Dec 8, 2020
@iohk-bors iohk-bors bot deleted the jordan/cardano-node-todos-121120 branch December 8, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@intricate intricate intricate approved these changes

@erikd erikd Awaiting requested review from erikd

@mrBliss mrBliss Awaiting requested review from mrBliss

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jimbo4350 @intricate @dcoutts