WIP: Propagate cardano-api Allegra/Mary changes to cardano-cli #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/propagate-api-changes
branch
2 times, most recently
from
e7e0aa0
to
ab9260d
Compare
dcoutts
reviewed
Nov 23, 2020
Comment on lines
224
to
236
| case era of | ||
| UseByronEra -> | ||
| withCardanoEra UseByronEra | ||
| $ \ _byronEra _byronEraStyle -> liftIO $ putTextLn "Not implemented yet" | ||
| UseShelleyEra -> | ||
| withCardanoEra UseShelleyEra | ||
| $ \_shelleyEra _shelleyEraStyle -> writeTx | ||
| UseAllegraEra -> | ||
| withCardanoEra UseAllegraEra | ||
| $ \ _allegraEra _allegraEraStyle -> writeTx | ||
| UseMaryEra -> | ||
| withCardanoEra UseMaryEra | ||
| $ \ _maryEra _maryEraStyle -> writeTx |
There was a problem hiding this comment.
This should be the other way around:
withCardanoEra useera $ \_era _eraStyle ->
case era of
ByronEra -> ...
ShelleyEra -> ...
AllegraEra -> ...
MaryEra -> ...
etc
Jimbo4350
force-pushed
the
jordan/propagate-api-changes
branch
2 times, most recently
from
4a311bc
to
fce6a22
Compare
intricate
force-pushed
the
jordan/propagate-api-changes
branch
2 times, most recently
from
cf35676
to
c54cbfd
Compare
Jimbo4350
force-pushed
the
jordan/propagate-api-changes
branch
from
c54cbfd
to
4d37948
Compare
Introduce a TxBodyContent type containing all the tx body fields. This type now covers all eras, including Byron. All the fields other than inputs and outputs are era-dependent: whether they're supported, and if so required or optional. We introduce a slew of types to cover which fields are supported in which eras. This makes a lot of things more uniform. Also complete the conversion functions into the underlying ledger types. This should now provide full support for the current Allegra and Mary eras. It has stubs for the auxiliary scripts which will be supported in the ledger shortly. This patch does the minimal CLI updates but does not update the tests. We may yet find we need some more type classes, or extensions to existing classes to make using this convenient.
This is just the initial step: the supporting functions remain either monomorphic, or with error cases for the Allegra and Mary eras.
Rather than separate per-era instances we have one general instance for both SerialiseAsCBOR and HasTextEnvelope.
Now needs a custom impl due to the GADT
Apply the same trick as before, but now to the Witness type. Remove unnecessary era-specific constructors. We have constructors for different kinds of witness, but the three Shelley style ones cover all Shelley-based eras. This is just the change of representation: the supporting functions remain either monomorphic, or with error cases for the Allegra and Mary eras. Comment out the Eq & Show instance for now. To restore in the next.
Now a single instance, but hand-written due to the GADTs.
Now a single instance, but hand-written due to the GADTs.
Same pattern we've used elsewhere. Add pattern aliases for compatibility.
Rather than separate per-era instances we have one general instance for SerialiseAsCBOR and HasTextEnvelope.
With a single era-paramaterised impl for all Shelley-based eras
Use a single era-paramaterised impl for all Shelley-based eras
Use a single era-paramaterised impl for all Shelley-based eras
Use a single era-paramaterised impl for all Shelley-based eras
And export HasScriptFeatures. Both of these will be useful in the CLI implementation.
Jimbo4350
force-pushed
the
jordan/propagate-api-changes
branch
from
4d37948
to
e766b74
Compare
Defaults to --shelley-era
Jimbo4350
force-pushed
the
jordan/propagate-api-changes
branch
2 times, most recently
from
79bd697
to
cb66e64
Compare
Jimbo4350
force-pushed
the
jordan/propagate-api-changes
branch
from
cb66e64
to
6563701
Compare
|
Replaced by #2129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2111