-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated help text for query ledger/protocol-state #2126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified that these commands are not intended for general use, and pointed to the underlying data structures for more information about content
kevinhammond
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
November 25, 2020 16:21
JaredCorduan
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dcoutts
approved these changes
Nov 25, 2020
bors r+ |
intricate
approved these changes
Nov 25, 2020
iohk-bors bot
added a commit
that referenced
this pull request
Nov 25, 2020
2092: Implement Multi-Asset JSON instances r=dcoutts a=Jimbo4350 Multi-Asset JSON is of the following format: ```json { "fooPolicyId": { "fooAssetName": 42 }, "barPolicyId": { "barAssetName": 84 }, "lovelace": 3 } ``` 2126: Updated help text for query ledger/protocol-state r=intricate a=kevinhammond Clarified that these commands are not intended for general use, and pointed to the underlying data structures for more information about content Co-authored-by: Jordan Millar <jordan.millar@iohk.io> Co-authored-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>
Build failed (retrying...): |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 25, 2020
2092: Implement Multi-Asset JSON instances r=dcoutts a=Jimbo4350 Multi-Asset JSON is of the following format: ```json { "fooPolicyId": { "fooAssetName": 42 }, "barPolicyId": { "barAssetName": 84 }, "lovelace": 3 } ``` 2126: Updated help text for query ledger/protocol-state r=intricate a=kevinhammond Clarified that these commands are not intended for general use, and pointed to the underlying data structures for more information about content Co-authored-by: Jordan Millar <jordan.millar@iohk.io> Co-authored-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>
Build failed (retrying...): |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified that these commands are not intended for general use, and pointed to the underlying data structures for more information about content