Update simple script documentation with Allegra time locking scripts #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/update-simple-script-docs
branch
from
6148250
to
2f4f219
Compare
intricate
reviewed
Dec 3, 2020
Jimbo4350
force-pushed
the
jordan/update-simple-script-docs
branch
4 times, most recently
from
26f5462
to
c6b5742
Compare
intricate
reviewed
Dec 3, 2020
Jimbo4350
force-pushed
the
jordan/update-simple-script-docs
branch
from
8368b7a
to
7a9a06a
Compare
intricate
approved these changes
Dec 10, 2020
|
bors r+ |
|
👎 Rejected by too few approved reviews |
|
bors r+ |
|
Canceled. |
|
bors r+ |
|
bors r+ |
|
Already running a review |
|
bors r |
|
Build failed: |
dcoutts
reviewed
Dec 10, 2020
doc/reference/simple-scripts.md
Outdated
| address. The authorisation condition to use the address is that one holds the | ||
| secret (signing) part of the cryptographic key (for that address) and thus be | ||
| able to make a cryptographic signature for that key. | ||
|
|
||
| The script-based addresses use a script per address. The authorisation | ||
| condition to use the address is that the _evaluation_ of the script for the | ||
| address results in success. The script expresses the authorisation conditions | ||
| and evaluation of the script tests if those conditions are met. For example, a | ||
| and evaluation of script tests if those conditions are met. For example, a |
There was a problem hiding this comment.
the definite article was needed here
doc/reference/simple-scripts.md
Outdated
| In the Allegra and later eras the simple multisig script language above is | ||
| extended with two additional terms for expressing conditions on the time. | ||
| In the Allegra and later eras, the simple multisig script language above is | ||
| extended with two additional terms for expressing any time conditions. |
There was a problem hiding this comment.
It's not any condition on time, only certain conditions can be expresses. For example I cannot express that it is a Tuesday.
Document the Allegra time locking features. Wewrite the introductory explanation of scripts in general. Generalise from talking only about multi-sig to talking about the simple script language more generally, including the Allegra extensions. Co-authored-by: Jordan Millar <jordan.millar@iohk.io> Co-authored-by: olgahryniuk <67585499+olgahryniuk@users.noreply.github.com>
dcoutts
force-pushed
the
jordan/update-simple-script-docs
branch
from
55bda58
to
31eb810
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.