Added an example Allegra to Mary script #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
requested review from
dcoutts,
erikd,
mrBliss and
newhoggy
as code owners
kantp
approved these changes
Dec 4, 2020
dcoutts
approved these changes
Dec 4, 2020
dcoutts
force-pushed
the
jc/allegra-to-mary-example-script
branch
from
36c50f7
to
fd0fb90
Compare
There is now a script in scripts/shelley-allegra/ which continues the example by providing the transition from Allegra to Mary.
In particular shelley-allegra -> byron-to-mary since it in fact now starts in Byron and can transition all the way through to Mary. Also rename byron-shelley -> byron-to-shelley for consistency
dcoutts
force-pushed
the
jc/allegra-to-mary-example-script
branch
from
fd0fb90
to
78498b7
Compare
To get the txid of a transaction that was created in the format used by the byron sub-commands (which is sadly different from the Shelley sub-commands). This is really useful to be able to spend from the Byron UTxO, since we need to know the txids to spend, and getting them from a utxo query is rather fragile.
That is, extend the cardano-cli transaction txid command with a flag to specify a tx file, as an alternative to the existing --tx-body-file flag which expects a txbody. This lets us get a txid from either a tx body or tx, which is handy. This is also then symmetric with the byron transaction txid command.
The default Byron genesis setup has 2 BFT nodes, and for historical
reasons the Byonr genesis command creates the same number of initial
UTxO entries as BFT nodes ("rich men" in legacy terminology).
Previously the script only got one of these UTxOs into a Byron and then
Shelley address, so only one was easily spendable.
It is useful to have both because that way we can delegate all the stake
to the stake pool, and have it make more blocks. Also a second utxo
makes it easier to play around with half the funds for experimenting
with Allegra or Mary era transactions without breaking the delegation to
the stake pool for the other half.
This replaces the fragile method of getting the txids from the utxo
query with a more robust method using the new byron txid command to get
the txid of the actual txs.
to use the `cardano-cli transaction txid` endpoint, instead of grep and awk
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 4, 2020
2169: Added an example Allegra to Mary script r=dcoutts a=JaredCorduan I've added a script in `scripts/shelley-allegra/` which continues the example by providing the transition from Allegra to Mary. The directory named "shelley-allegra" probably doesn't make sense anymore. Shall I rename it to `bryon-to-mary`? Co-authored-by: Jared Corduan <jaredcorduan@gmail.com> Co-authored-by: Duncan Coutts <duncan@well-typed.com> Co-authored-by: Philipp Kant <philipp.kant@iohk.io>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 18, 2020
1882: remove non-nix installs in nix installation instructions r=Jimbo4350 a=disassembler 2177: Add scripts that mint and burn multi assets in Mary. r=Jimbo4350 a=kantp This is for testing creation and destruction of multi assets in the Mary era. It should be merged after #2169 and #2176, since it relies on both of them. Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io> Co-authored-by: Philipp Kant <philipp.kant@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a script in
scripts/shelley-allegra/which continues the example by providing the transition from Allegra to Mary.The directory named "shelley-allegra" probably doesn't make sense anymore. Shall I rename it to
bryon-to-mary?