Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass a metrics tracer to teeTraceChainTip #2175

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Pass a metrics tracer to teeTraceChainTip #2175

merged 1 commit into from
Dec 4, 2020

Conversation

intricate
Copy link
Contributor

@intricate intricate commented Dec 4, 2020 •
edited
Loading

After #2158, it seems that ChainDB metrics were mistakenly being logged to cardano.node instead of cardano.node.metrics. This PR fixes that.

@intricate intricate self-assigned this Dec 4, 2020
dcoutts
dcoutts approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets us every single time.

We need to change the way we trace things so that metrics are a different type and always get routed to the right place, rather than relying on stringy names.

@dcoutts
Copy link
Contributor

dcoutts commented Dec 4, 2020

bors merge

deepfire
deepfire approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Luke!

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 4, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit fb389c0 into master Dec 4, 2020
@iohk-bors iohk-bors bot deleted the intricate/metrics-tracer-teeTraceChainTip branch December 4, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@dcoutts dcoutts dcoutts approved these changes

@erikd erikd Awaiting requested review from erikd

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@mrBliss mrBliss Awaiting requested review from mrBliss

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees

@intricate intricate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@intricate @dcoutts @deepfire