-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network tracers #2178
Network tracers #2178
Conversation
c884877
to
8254e3f
Compare
8254e3f
to
a7a4a8d
Compare
Trace the agancy together with a mini-protocol message tag. Ouroboros-Network was able to do that for some time, this patch provides necessary tracing class instance changes.
When using 'ScText' format, Show instances provide much more readable logging output.
a7a4a8d
to
49942cf
Compare
getSeverityAnnotation BlockFetch.CompletedBlockFetch {} = Info | ||
getSeverityAnnotation BlockFetch.CompletedFetchBatch {} = Info | ||
getSeverityAnnotation BlockFetch.RejectedFetchBatch {} = Info | ||
getSeverityAnnotation BlockFetch.ClientTerminating {} = Notice | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coot, do you think it can be:
getSeverityAnnotation BlockFetch.ClientTerminating {} = Notice | |
getSeverityAnnotation _ = Info |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have something like 20 hot peers, so these messages will rather be sparse. I thought that initially its better to start with Notice
and we can move to Info
later. Are you ok with it @deepfire ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small nit.
Thank you, @coot!
bors merge |
2178: Network tracers r=coot a=coot This PR improves network tracers; originally done in `coot/p2p-integration` branch, but this part is indepentend of p2p changes in `ouroboros-network`. This PR consists of two patches: - Improved mini-protocol tracers Which includes agency together with the mini-protocol message tag. - networking trace using show instances rather than json values Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
bors merge |
Build succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR improves network tracers; originally done in
coot/p2p-integration
branch,but this part is indepentend of p2p changes in
ouroboros-network
. This PR consists of two patches:Improved mini-protocol tracers
Which includes agency together with the mini-protocol message tag.
networking trace using show instances rather than json values