Add API support for queries for protocol params. #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
requested review from
erikd,
intricate,
mrBliss and
newhoggy
as code owners
|
The first two patches are from PR 2238. This can be rebased once they're merged. |
newhoggy
approved these changes
Jan 7, 2021
Before we add more things into that module.
To go along with the existing ProtocolParametersUpdate type. This new one will be used for the query that returns the current param values.
The node keeps the values of the params that are fixed in the genesis file. -- Please enter the commit message for your changes. Lines starting
Several kinds of params: 1. current values of updateable protocol params 2. any pending proposed param updates 3. the non-updateable params fixed in the (Shelley) genesis file
dcoutts
force-pushed
the
dcoutts/api-ipc-query-yet-more
branch
from
aa83a0d
to
b5abac0
Compare
Jimbo4350
approved these changes
Jan 8, 2021
| -- Genesis paramaters | ||
| -- | ||
|
|
||
| data GenesisParameters = |
| -- :: Set StakeAddress | ||
| -- -> QueryInShelleyBasedEra (Map StakeAddress Lovelace, | ||
| -- Map StakeAddress PoolId) | ||
| QueryStakeAddresses |
There was a problem hiding this comment.
Oops. You can take over this PR.
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several kinds of params: