Add SerialiseAsRawBytes instances for PolicyId and AssetName #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
requested review from
erikd,
intricate,
mrBliss and
newhoggy
as code owners
Jimbo4350
approved these changes
Jan 8, 2021
Plus handy Show/IsString instances.
dcoutts
force-pushed
the
dcoutts/api-serialise-policyid
branch
from
27ab20d
to
d20e9eb
Compare
rvl
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Jan 9, 2021
rvl
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Jan 10, 2021
rvl
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Jan 11, 2021
|
I have tried using the serialise instances from this branch and it works (of course). |
6 tasks
rvl
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Jan 11, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Jan 12, 2021
2400: Make wallet run on Mary r=Anviking a=Anviking # Issue Number ADP-623 # Overview - [x] Make the wallet run on Mary, - [x] MA Value types are converted to/from TokenBundles. - [x] Roundtrip tests for Value/TokenBundle - [x] Fix disabled era error https://input-output-rnd.slack.com/archives/CFKLUH4R0/p1608146419455500 - [x] Test cluster does hard forks at start up - instantly. - [x] Uses latest cardano-node master branch, with IntersectMBO/cardano-node#2270 merged. # Comments - I imagine properly thinking about and removing the duplication would be pretty fun. (rvl: we can do that in the next PR) - Local test cluster changes for testing in multiple eras ⇒ #2438 Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Jan 12, 2021
2400: Make wallet run on Mary r=Anviking a=Anviking # Issue Number ADP-623 # Overview - [x] Make the wallet run on Mary, - [x] MA Value types are converted to/from TokenBundles. - [x] Roundtrip tests for Value/TokenBundle - [x] Fix disabled era error https://input-output-rnd.slack.com/archives/CFKLUH4R0/p1608146419455500 - [x] Test cluster does hard forks at start up - instantly. - [x] Uses latest cardano-node master branch, with IntersectMBO/cardano-node#2270 merged. # Comments - I imagine properly thinking about and removing the duplication would be pretty fun. (rvl: we can do that in the next PR) - Local test cluster changes for testing in multiple eras ⇒ #2438 Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Jan 12, 2021
2400: Make wallet run on Mary r=Anviking a=Anviking # Issue Number ADP-623 # Overview - [x] Make the wallet run on Mary, - [x] MA Value types are converted to/from TokenBundles. - [x] Roundtrip tests for Value/TokenBundle - [x] Fix disabled era error https://input-output-rnd.slack.com/archives/CFKLUH4R0/p1608146419455500 - [x] Test cluster does hard forks at start up - instantly. - [x] Uses latest cardano-node master branch, with IntersectMBO/cardano-node#2270 merged. # Comments - I imagine properly thinking about and removing the duplication would be pretty fun. (rvl: we can do that in the next PR) - Local test cluster changes for testing in multiple eras ⇒ #2438 Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Jan 12, 2021
2400: Make wallet run on Mary r=Anviking a=Anviking # Issue Number ADP-623 # Overview - [x] Make the wallet run on Mary, - [x] MA Value types are converted to/from TokenBundles. - [x] Roundtrip tests for Value/TokenBundle - [x] Fix disabled era error https://input-output-rnd.slack.com/archives/CFKLUH4R0/p1608146419455500 - [x] Test cluster does hard forks at start up - instantly. - [x] Uses latest cardano-node master branch, with IntersectMBO/cardano-node#2270 merged. # Comments - I imagine properly thinking about and removing the duplication would be pretty fun. (rvl: we can do that in the next PR) - Local test cluster changes for testing in multiple eras ⇒ #2438 Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus handy Show/IsString instances.