-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cardano-cli transaction view
#2348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Is this done now? Its still marked as draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Can you paste an example of the output on this PR?
Minimal transaction:
|
@erikd @disassembler |
There is some duplication of code, but I can't figure out a good solution due to complicated type inference in presence of open type families. |
@cblp I would squash the commits into one commit. I'd also update the commit message with something like:
When we get closer to a release, someone has to go through the commit messages to figure out what to include in the change log. It's better to be a bit more descriptive to make their life easier. 😄 |
With YAML, we can remove syntactical noise at no pay:
Should we? |
Aren't commits squashed automatically during merge? |
8c73d3b
to
59c2775
Compare
Tests failed with
How to investigate this? |
cardano-cli transation view
cardano-cli transaction view
…cli transaction view`
59c2775
to
d5c9660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bors r+ |
Build succeeded: |
No description provided.