CAD-2572 Direct submission of the ChainSync headers served metric to EKG #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jutaro
requested review from
DavidEichmann,
dcoutts,
erikd,
intricate,
Jimbo4350 and
newhoggy
as code owners
deepfire
approved these changes
Feb 16, 2021
deepfire
changed the title
deepfire
changed the title
deepfire
force-pushed
the
cad-2572-ekg-direct
branch
from
bd246fe
to
ae71cb2
Compare
newhoggy
reviewed
Feb 17, 2021
newhoggy
reviewed
Feb 17, 2021
newhoggy
reviewed
Feb 17, 2021
jutaro
force-pushed
the
cad-2572-ekg-direct
branch
from
ae71cb2
to
1b32b5f
Compare
|
💯 |
newhoggy
approved these changes
Feb 18, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iohk-monitoring-frameworkto the latestmaster, that includes EKG server extraction.EKGDirect-- a direct handle onto the EKG server/store used by the EKG backend of the logging framework.cardano.node.metrics.served.header.counter.intto the switchboard.EKGDirect, instead.