Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-2564: trace KES metrics even if there is error #2373

Merged
merged 1 commit into from
Feb 25, 2021
Merged

CAD-2564: trace KES metrics even if there is error #2373

merged 1 commit into from
Feb 25, 2021

Conversation

denisshevchenko
Copy link
Contributor

@denisshevchenko denisshevchenko commented Feb 16, 2021 •
edited
Loading

Previously, KES-related information wasn't traced if the node has expired KES-key. Now KES-related information will be traced anyway.

Now, even if KES-key is poisoned, KES-metrics is here:

$ curl 0.0.0.0:12798/metrics | grep KES
cardano_node_metrics_operationalCertificateExpiryKESPeriod_int 72
cardano_node_metrics_currentKESPeriod_int 0
cardano_node_metrics_remainingKESPeriods_int 0
cardano_node_metrics_operationalCertificateStartKESPeriod_int 10

@denisshevchenko denisshevchenko self-assigned this Feb 16, 2021
@denisshevchenko denisshevchenko force-pushed the cad-2564-kes-metrics-when-expired branch 2 times, most recently from 513a32d to 131540a Compare February 16, 2021 15:37
deepfire
deepfire approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Jimbo4350
Jimbo4350 approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denisshevchenko
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 25, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 40c46ec into master Feb 25, 2021
@iohk-bors iohk-bors bot deleted the cad-2564-kes-metrics-when-expired branch February 25, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@deepfire deepfire deepfire approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@intricate intricate Awaiting requested review from intricate

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees

@denisshevchenko denisshevchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denisshevchenko @deepfire @Jimbo4350