-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify submit-api to accept cbor transactions instead #2491
Modify submit-api to accept cbor transactions instead #2491
Conversation
67bacb5
to
1610818
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead? Instead of what? It makes sense to accept CBOR, but removing something else to replace it with CBOR does not make too much sense.
This comment is the context: #2370 (comment) My understanding is that CBOR without envelope is what the old version of We would probably do some MIME type thing to support both, I haven't figured that out yet. |
1610818
to
870e643
Compare
870e643
to
ef2968d
Compare
9ba8d31
to
fc0afd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I linked to a commit with a suggestion (up to you if you want to use it). Just squash the commits and you can merge 👍
] | ||
-> Either RawCborDecodeError b | ||
deserialiseAnyOf ts te = let (es, as) = partitionEithers results in maybe (errors es) Right (listToMaybe as) | ||
where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative suggestion: 862f692
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken your suggestion to use list instead of non-empty-list, but also fixed up the logic like this: If there is at least successful decode, always take the first one.
b52b91c
to
06ca656
Compare
bors merge |
Build succeeded: |
No description provided.