Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ToJSON instance for getting era in query tip command #2562

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Use ToJSON instance for getting era in query tip command #2562

merged 1 commit into from
Mar 31, 2021

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy
Copy link
Contributor Author

Using ToJSON instance instead. This results in the era name being capitalised:

CARDANO_NODE_SOCKET_PATH='/Users/jky/Library/Application Support/Daedalus Mainnet/cardano-node.socket' ./dist-newstyle/build/x86_64-osx/ghc-8.10.4/cardano-cli-1.26.1/x/cardano-cli/build/cardano-cli/cardano-cli query tip --mainnet
{
    "epoch": 256,
    "hash": "c7b692a73d16a8b3bc518c6a87fd9050376f3d0a389212bae90f34af08cd297f",
    "slot": 25608927,
    "block": 5530601,
    "era": "Mary"
}

@newhoggy newhoggy force-pushed the use-ToJSON-instance-for-getting-era branch from 389fd4b to f463e8a Compare March 31, 2021 07:25
@newhoggy newhoggy force-pushed the use-ToJSON-instance-for-getting-era branch from f463e8a to e4d4324 Compare March 31, 2021 08:33
@Jimbo4350 Jimbo4350 self-requested a review March 31, 2021 08:34
Jimbo4350
Jimbo4350 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@newhoggy newhoggy force-pushed the use-ToJSON-instance-for-getting-era branch from e4d4324 to 1340955 Compare March 31, 2021 08:38
@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 31, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit c1d32f4 into master Mar 31, 2021
@iohk-bors iohk-bors bot deleted the use-ToJSON-instance-for-getting-era branch March 31, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newhoggy @Jimbo4350