Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query tip JSON in documentation #2598

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy force-pushed the update-query-tip-json branch 2 times, most recently from b4c3a96 to a3baaeb Compare April 12, 2021 04:15
@newhoggy newhoggy changed the title Update query tipe JSON in documentation Update query tip JSON in documentation Apr 12, 2021
@newhoggy newhoggy marked this pull request as ready for review April 12, 2021 06:31
@newhoggy newhoggy requested review from Jimbo4350, dcoutts and erikd and removed request for Jimbo4350 April 12, 2021 06:32
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question about the KES period calculation

"blockNo": 16829,
"headerHash": "3e6f59b10d605e7f59ba8383cb0ddcd42480ddcc0a85d41bad1e4648eb5465ad",
"slotNo": 369200
"epoch": 259,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

--allegra-era Specify the Allegra era
--mary-era Specify the Mary era
--mary-era Specify the Mary era (default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


expr 8520857 / 129600
> 65
expr 26633911 / 129600
Copy link
Contributor

@Jimbo4350 Jimbo4350 Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this calculation valid? For a pure Shelley testnet it would be but for mainnet? This is how it's calculated.

@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 12, 2021

@iohk-bors iohk-bors bot merged commit e5910db into master Apr 12, 2021
@iohk-bors iohk-bors bot deleted the update-query-tip-json branch April 12, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants