Add getTransactionBodyContent

[cblp]

No description provided.

[Jimbo4350]

Nice work, some comments below.

[Jimbo4350]

@cblp So following the style of cardano-api this is what we are aiming for. You're heading in the right direction but we can further refactor to the following:

getTxBodyContent :: TxBody era -> TxBodyContent ViewTx era
getTxBodyContent (ByronTxBody annot) = getByronTxBodyContent annot
getTxBodyContent (ShelleyTxBody sbe txBody scripts mAuxData) =
  fromLedgerTxBody sbe txBody

fromLedgerTxBody
  :: ShelleyBasedEra era
  -> Ledger.TxBody (ShelleyLedgerEra era)
  -> TxBodyContent ViewTx era
fromLedgerTxBody sbe txBod =
  TxBodyContent
    { txIns = fromLedgerTxIns sbe txBod
    , txOuts = error ""
    , txFee = error ""
    , txValidityRange = error ""
    , txMetadata = error ""
    , txAuxScripts = error ""
    , txWithdrawals = error ""
    , txCertificates = error ""
    , txUpdateProposal = error ""
    , txMintValue = error ""
    }

fromLedgerTxIns
  :: ShelleyBasedEra era
  -> Ledger.TxBody (ShelleyLedgerEra era)
  -> [(TxIn,BuildTxWith ViewTx (Witness WitCtxTxIn era))]
fromLedgerTxIns sbe ledTxBody =
  case sbe of
    ShelleyBasedEraShelley ->
      [ (fromShelleyTxIn input, ViewTx)
      | input <- toList $ Shelley._inputs ledTxBody
      ]
    ShelleyBasedEraAllegra ->
      [ (fromShelleyTxIn input, ViewTx)
      | input <- toList $ Allegra.inputs' ledTxBody
      ]
    ShelleyBasedEraMary ->
      [ (fromShelleyTxIn input, ViewTx)
      | input <- toList $ Mary.inputs' ledTxBody
      ]

We can also remove the error checking as we already do that when constructing a TxBody era i.e :

makeShelleyTransactionBody :: ShelleyBasedEra era
                           -> TxBodyContent BuildTx era
                           -> Either (TxBodyError era) (TxBody era)                       

The type signature of fromLedgerTxBody will need to be updated with the other things e.g Maybe (Ledger.AuxiliaryData (ShelleyLedgerEra era)) but this is the general format.

[cblp]

restored txMetadata code

[cblp]

@Jimbo4350 transposed code by field-then-era

[Jimbo4350]

Nice work! LGTM

[cblp]

bors merge

[iohk-bors]

Build succeeded:

• ci/hydra-build:required
• buildkite/cardano-node
• ci/hydra-eval