Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-2894 add wallet #2676

Merged
merged 1 commit into from
Jun 21, 2021
Merged

CAD-2894 add wallet #2676

merged 1 commit into from
Jun 21, 2021

Conversation

MarcFontaine
Copy link
Contributor

@MarcFontaine MarcFontaine commented May 6, 2021 •
edited
Loading

  • Use wallet abstraction in benchmarking scripts.
  • Refactor SubmissionClient.

@MarcFontaine MarcFontaine added the enhancement New feature or request label May 6, 2021
@MarcFontaine MarcFontaine self-assigned this May 6, 2021
@MarcFontaine MarcFontaine force-pushed the mafo/tx-gen-wallet branch 2 times, most recently from bf54fdc to e38044b Compare May 12, 2021 09:12
@MarcFontaine MarcFontaine force-pushed the mafo/tx-gen-wallet branch 5 times, most recently from 7482f15 to 712fa85 Compare May 20, 2021 14:34
@MarcFontaine MarcFontaine force-pushed the mafo/tx-gen-wallet branch 4 times, most recently from 76bf817 to f564c13 Compare June 2, 2021 09:04
@MarcFontaine MarcFontaine force-pushed the mafo/tx-gen-wallet branch 2 times, most recently from 63c4e91 to ddd2a85 Compare June 8, 2021 16:14
@MarcFontaine MarcFontaine force-pushed the mafo/tx-gen-wallet branch 2 times, most recently from d4e753f to f9c642a Compare June 15, 2021 13:23
@deepfire deepfire force-pushed the mafo/tx-gen-wallet branch 2 times, most recently from c3d9bc8 to 5433c33 Compare June 15, 2021 14:45
@MarcFontaine MarcFontaine marked this pull request as ready for review June 21, 2021 12:20
deepfire
deepfire approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you Marc!

@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 21, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 13d71da into master Jun 21, 2021
@iohk-bors iohk-bors bot deleted the mafo/tx-gen-wallet branch June 21, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

Assignees

@MarcFontaine MarcFontaine

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcFontaine @deepfire