Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-2907 trace: AddedToCurrentChain/SwitchedToAFork: log elongation as headBlockNo Δ #2678

Merged
merged 1 commit into from
May 12, 2021
Merged

CAD-2907 trace: AddedToCurrentChain/SwitchedToAFork: log elongation as headBlockNo Δ #2678

merged 1 commit into from
May 12, 2021

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented May 6, 2021 •
edited
Loading

This adds an chainLengthDelta field to the AddedToCurrentChain and SwitchedToAFork ChainDB traces.

@deepfire deepfire requested review from nc6 and nfrisby May 6, 2021 15:24
@nc6
Copy link
Contributor

nc6 commented May 6, 2021

The term "elongation" can be a little confusing here, I might just stick with "chainLengthIncrease"

@deepfire
Copy link
Contributor Author

deepfire commented May 6, 2021

The term "elongation" can be a little confusing here, I might just stick with "chainLengthIncrease"

Maybe chainLengthDelta then?

@newhoggy
Copy link
Contributor

newhoggy commented May 7, 2021

growth?

@deepfire
Copy link
Contributor Author

deepfire commented May 7, 2021 •
edited
Loading

@newhoggy, growth is similarly confusing (as are elongation and lengthIncrease) -- it suggests increase.

Whereas lengthDelta has no bias -- it's as neutral and precise as possible, I think...

@newhoggy
Copy link
Contributor

chainLengthDelta sounds good. 😁

@deepfire deepfire force-pushed the cad-2907-chain-elongation-trace branch from 2f75ca5 to 3f11549 Compare May 12, 2021 08:02
@nc6
Copy link
Contributor

nc6 commented May 12, 2021

Also fine with chainLengthDelta

@newhoggy newhoggy requested a review from nfrisby May 12, 2021 13:09
@deepfire deepfire force-pushed the cad-2907-chain-elongation-trace branch from 3f11549 to bc0bb69 Compare May 12, 2021 13:11
@deepfire
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 12, 2021
@iohk-bors @deepfire
Merge #2678
72caee6 
2678: CAD-2907 trace:  AddedToCurrentChain/SwitchedToAFork: log elongation as headBlockNo Δ r=deepfire a=deepfire

This adds an `chainLengthDelta` field to the `AddedToCurrentChain` and `SwitchedToAFork` ChainDB traces.

Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 12, 2021

Build failed:

@deepfire
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 12, 2021
@iohk-bors @deepfire
Merge #2678
879156e 
2678: CAD-2907 trace:  AddedToCurrentChain/SwitchedToAFork: log elongation as headBlockNo Δ r=deepfire a=deepfire

This adds an `chainLengthDelta` field to the `AddedToCurrentChain` and `SwitchedToAFork` ChainDB traces.

Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 12, 2021

Build failed:

@johnalotoski johnalotoski force-pushed the cad-2907-chain-elongation-trace branch from bc0bb69 to d69d201 Compare May 12, 2021 19:27
@johnalotoski johnalotoski force-pushed the cad-2907-chain-elongation-trace branch from d69d201 to 40ce82e Compare May 12, 2021 19:48
@johnalotoski
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 12, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 7949528 into master May 12, 2021
@iohk-bors iohk-bors bot deleted the cad-2907-chain-elongation-trace branch May 12, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nc6 nc6 nc6 approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@nfrisby nfrisby Awaiting requested review from nfrisby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deepfire @nc6 @newhoggy @johnalotoski @nfrisby @Jimbo4350