-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerImages: use binary-dist instead of custom hydra build product subtype #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbgi
added
WIP
Work In Progress (cannot be merged yet)
and removed
WIP
Work In Progress (cannot be merged yet)
labels
May 7, 2021
disassembler
approved these changes
May 10, 2021
cleverca22
approved these changes
May 10, 2021
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 11, 2021
2682: dockerImages: use binary-dist instead of custom hydra build product subtype r=jbgi a=jbgi so that docker images correctly appear for download on hydra: https://hydra.iohk.io/build/6289120 Currently on master: https://hydra.iohk.io/build/6287806 Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
Build failed: |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 11, 2021
2682: dockerImages: use binary-dist instead of custom hydra build product subtype r=jbgi a=jbgi so that docker images correctly appear for download on hydra: https://hydra.iohk.io/build/6289120 Currently on master: https://hydra.iohk.io/build/6287806 Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
Build failed: |
…ubtype so that docker images correctly appear for download on hydra.
jbgi
force-pushed
the
fixes/docker-hydra-build-product
branch
from
May 11, 2021 13:00
537caf2
to
814394e
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 11, 2021
2682: dockerImages: use binary-dist instead of custom hydra build product subtype r=jbgi a=jbgi so that docker images correctly appear for download on hydra: https://hydra.iohk.io/build/6289120 Currently on master: https://hydra.iohk.io/build/6287806 Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
Build failed: |
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that docker images correctly appear for download on hydra:
https://hydra.iohk.io/build/6289120
Currently on master:
https://hydra.iohk.io/build/6287806