Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli to allow Alonzo era queries #2727

Merged
merged 4 commits into from
May 31, 2021
Merged

Update cli to allow Alonzo era queries #2727

merged 4 commits into from
May 31, 2021

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented May 21, 2021 •
edited
Loading

No description provided.

@Jimbo4350 Jimbo4350 force-pushed the jordan/update-tx-submission-alonzo branch 5 times, most recently from ab332b2 to c994097 Compare May 27, 2021 11:46
@Jimbo4350 Jimbo4350 added the WIP Work In Progress (cannot be merged yet) label May 27, 2021
@Jimbo4350 Jimbo4350 force-pushed the jordan/update-tx-submission-alonzo branch from 9241270 to e64f74b Compare May 27, 2021 14:56
@jbgi jbgi force-pushed the jordan/update-tx-submission-alonzo branch 2 times, most recently from 563ea56 to 8e730b3 Compare May 27, 2021 16:50
@jbgi jbgi mentioned this pull request May 27, 2021
Merged
@jbgi jbgi force-pushed the jordan/update-tx-submission-alonzo branch from 64d15bc to c0b9d83 Compare May 27, 2021 23:06
@Jimbo4350 Jimbo4350 force-pushed the jordan/update-tx-submission-alonzo branch from c0b9d83 to d902c08 Compare May 29, 2021 08:43
@Jimbo4350 Jimbo4350 removed the WIP Work In Progress (cannot be merged yet) label May 29, 2021
@dcoutts
Copy link
Contributor

dcoutts commented May 31, 2021

Good stuff. I've cherry-picked most (or possibly all) of the changes from the first two commits here into #2759 and in the process I've reviewed, tweaked and extended them.

So I suggest rebasing on #2759 or master once that's merged.

@dcoutts dcoutts force-pushed the jordan/update-tx-submission-alonzo branch from d902c08 to aab23a0 Compare May 31, 2021 17:34
@dcoutts
Copy link
Contributor

dcoutts commented May 31, 2021

Rebased on master.

@dcoutts dcoutts force-pushed the jordan/update-tx-submission-alonzo branch from aab23a0 to 45bc383 Compare May 31, 2021 18:10
@Jimbo4350
Copy link
Contributor Author

LGTM!

dcoutts
dcoutts approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcoutts
Copy link
Contributor

dcoutts commented May 31, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 31, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 98a069e into master May 31, 2021
@iohk-bors iohk-bors bot deleted the jordan/update-tx-submission-alonzo branch May 31, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jimbo4350 @dcoutts