CAD-2907 tracing: improve usability of the ChainSync server traces #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of going through the Tip/Point serialisations this allows a more direct access to things that matter: 1. block hash 2. slot number 3. block number We only convert immediately necessary traces, but the portal has been opened and the call is out.
deepfire
requested review from
DavidEichmann,
dcoutts,
erikd,
Jimbo4350 and
newhoggy
as code owners
Jimbo4350
approved these changes
May 26, 2021
There was a problem hiding this comment.
LGTM! @deepfire can you include in the commit message that the log format is being changed here? This will make things clearer for @LaurenceIO when he is writing up the change logs.
deepfire
force-pushed
the
cad-2907-tracing
branch
from
e8479df
to
356fd7b
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of going through the Tip/Point serialisations
this allows a more direct access to things that matter:
We only convert immediately necessary traces, but the portal has been opened and the call is out.
Release-relevant information (cc @LaurenceIO): this PR changes structure of some of the traces configured by
TraceChainSyncHeaderServerandTraceChainSyncClientconfig options.