Tidy up the CLI tx out datum support #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than a mix of attoparsec and parsec. attoparsec is still used for Scientific values and JSON.
Simpler story with parsing, and with the internal handling. Parse it fully in the CLI parser so we don't need to parse later. Also properly report the use of output datums when it is not supported, rather than silently ignoring them.
For consistency with the --tx-out flag. This has not been released yet, so there are no backwards compat concerns.
Jimbo4350
approved these changes
Jun 9, 2021
newhoggy
approved these changes
Jun 9, 2021
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #2798