Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD-2907 workbench: Alonzo support #2831

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Jun 15, 2021

This makes the scripts/plutus/example-txin-locking-plutus-script.sh script work with the workbench:

  1. Alonzo-specific updates in the workbench genesis generation
  2. Adaptations in the script
  3. Small quality-of-life improvement: set CARDANO_NODE_SOCKET_PATH automatically inside the shell

Test with:

  1. make cls cluster-shell-dev CLUSTER_ARGS_EXTRA='--arg withHoogle false', and once inside the shell:
  2. ./scripts/plutus/example-txin-locking-plutus-script.sh
  3. cardano-cli transaction submit --tx-file example/work/alonzo.tx --testnet-magic 42

The last command should output: Transaction successfully submitted.

@deepfire deepfire force-pushed the cad-2907-workbench-alzo branch 2 times, most recently from 8216256 to 5eace83 Compare June 15, 2021 20:11
@MarcFontaine
Copy link
Contributor

The modified script will no longer work in the original context.
I.e. it will not work with the second cluster config.
It would be better to rename the new script and keep the old version.

Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@MarcFontaine
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 16, 2021
2831: CAD-2907 workbench: Alonzo support r=MarcFontaine a=deepfire

This makes the `scripts/plutus/example-txin-locking-plutus-script.sh` script work with the workbench:

1. Alonzo-specific updates in the workbench genesis generation
2. Adaptations in the script
3. Small quality-of-life improvement: set `CARDANO_NODE_SOCKET_PATH` automatically inside the shell

Test with:

1. `make cls cluster-shell-dev CLUSTER_ARGS_EXTRA='--arg withHoogle false'`, and once inside the shell:
2. `./scripts/plutus/example-txin-locking-plutus-script.sh`
3. `cardano-cli transaction submit --tx-file example/work/alonzo.tx --testnet-magic 42`

The last command should output: `Transaction successfully submitted.`

Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
# Conflicts:
#	scripts/plutus/example-txin-locking-plutus-script.sh
@deepfire
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 16, 2021

@iohk-bors iohk-bors bot merged commit 2b9d75e into master Jun 16, 2021
@iohk-bors iohk-bors bot deleted the cad-2907-workbench-alzo branch June 16, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants