-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAD-2907 workbench: Alonzo support #2831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfire
requested review from
DavidEichmann,
dcoutts,
erikd,
Jimbo4350 and
newhoggy
as code owners
June 15, 2021 19:57
deepfire
force-pushed
the
cad-2907-workbench-alzo
branch
2 times, most recently
from
June 15, 2021 20:11
8216256
to
5eace83
Compare
The modified script will no longer work in the original context. |
MarcFontaine
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 16, 2021
2831: CAD-2907 workbench: Alonzo support r=MarcFontaine a=deepfire This makes the `scripts/plutus/example-txin-locking-plutus-script.sh` script work with the workbench: 1. Alonzo-specific updates in the workbench genesis generation 2. Adaptations in the script 3. Small quality-of-life improvement: set `CARDANO_NODE_SOCKET_PATH` automatically inside the shell Test with: 1. `make cls cluster-shell-dev CLUSTER_ARGS_EXTRA='--arg withHoogle false'`, and once inside the shell: 2. `./scripts/plutus/example-txin-locking-plutus-script.sh` 3. `cardano-cli transaction submit --tx-file example/work/alonzo.tx --testnet-magic 42` The last command should output: `Transaction successfully submitted.` Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
# Conflicts: # scripts/plutus/example-txin-locking-plutus-script.sh
deepfire
force-pushed
the
cad-2907-workbench-alzo
branch
from
June 16, 2021 15:06
33249c1
to
d378762
Compare
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
scripts/plutus/example-txin-locking-plutus-script.sh
script work with the workbench:CARDANO_NODE_SOCKET_PATH
automatically inside the shellTest with:
make cls cluster-shell-dev CLUSTER_ARGS_EXTRA='--arg withHoogle false'
, and once inside the shell:./scripts/plutus/example-txin-locking-plutus-script.sh
cardano-cli transaction submit --tx-file example/work/alonzo.tx --testnet-magic 42
The last command should output:
Transaction successfully submitted.