Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API support for extra node queries #2843

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Jun 18, 2021

Extended the QueryUTxO with a QueryUTxOFilter param which has a new case
for QueryUTxOByTxIn.

Added QueryStakePools and QueryStakePoolParameters.

Added top level query QuerySystemStart

Also extend the cardano-cli query utxo with a --tx-in flag to filter by txin, and change the default from returning the whole utxo to there being no default. Added a --whole-utxo flag for the case that you really do what the whole thing.

This change may affect some examples and scripts.

@dcoutts
Copy link
Contributor Author

dcoutts commented Jun 18, 2021

This depends on IntersectMBO/ouroboros-network#3220 and should be rebased once that PR is merged to master, so we select a commit from the master branch.

@dcoutts dcoutts force-pushed the dcoutts/api-extra-queries branch 2 times, most recently from e9b6472 to 87cccee Compare June 18, 2021 17:44
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Extended the QueryUTxO with a QueryUTxOFilter param which has a new case
for QueryUTxOByTxIn.

Added QueryStakePools and QueryStakePoolParameters.

Added top level query QuerySystemStart

Rewind the plutus repo slightly, to match the version being used by the
ledger and network repo packages.
Simplify the types by reusing the API QueryUTxOFilter type.
Its convenient in tiny testnets but insanely huge on the mainnet, or
even the longer running testnets. It's unhelpful to default to that.

So we now require using the --whole-utxo flag.
@dcoutts
Copy link
Contributor Author

dcoutts commented Jun 21, 2021

Rebased on master and updated to refer to the commit from the master branch of the network repo, now that IntersectMBO/ouroboros-network#3220 is merged.

@dcoutts
Copy link
Contributor Author

dcoutts commented Jun 21, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 21, 2021

@iohk-bors iohk-bors bot merged commit bc247f5 into master Jun 21, 2021
@iohk-bors iohk-bors bot deleted the dcoutts/api-extra-queries branch June 21, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants