Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to choose socket file #2855

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Make it possible to choose socket file #2855

merged 1 commit into from
Jun 23, 2021

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy force-pushed the make-it-possible-to-choose-socket-file branch 2 times, most recently from c1f1470 to 17117ba Compare June 23, 2021 07:01
newhoggy
newhoggy commented Jun 23, 2021
View reviewed changes
scripts/plutus/simple-minting-policy.sh
@@ -13,7 +13,7 @@ set -o pipefail

# Step 1 - Send ADA to token script owner

export CARDANO_NODE_SOCKET_PATH=example/node-bft1/node.sock
export CARDANO_NODE_SOCKET_PATH="${CARDANO_NODE_SOCKET_PATH:-example/node-bft1/node.sock}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a default value, but allow the caller of the script to define another value.

@newhoggy newhoggy force-pushed the make-it-possible-to-choose-socket-file branch 3 times, most recently from fbc7193 to 13efbb0 Compare June 23, 2021 07:43
@newhoggy
Copy link
Contributor Author

Example run:

$ CARDANO_NODE_SOCKET_PATH=test.socket WORK="/private/var/folders/zh/ln41q4zs52x2fd61rxccmq640000gn/T/chairman/test-96968fe06fa63acf" UTXO_VKEY=/private/var/folders/zh/ln41q4zs52x2fd61rxccmq640000gn/T/chairman/test-96968fe06fa63acf/shelley/utxo-keys/utxo1.vkey UTXO_SKEY=/private/var/folders/zh/ln41q4zs52x2fd61rxccmq640000gn/T/chairman/test-96968fe06fa63acf/shelley/utxo-keys/utxo1.skey ./scripts/plutus/example-txin-locking-plutus-script.sh
Always succeeds Plutus script in use. Any datum and redeemer combination will succeed.
Script at: scripts/plutus/scripts/untyped-always-succeeds-txin.plutus
Transaction successfully submitted.
Pausing for 5 seconds...
Submit the tx with plutus script and wait 5 seconds...
Transaction successfully submitted.

Querying UTxO at addr_test1vpqgspvmh6m2m5pwangvdg499srfzre2dd96qq57nlnw6yctpasy4. If there is ADA at the address the Plutus script successfully executed!

                           TxHash                                 TxIx        Amount
--------------------------------------------------------------------------------------
56e73127013a279eba46c2fa988caf6982d1f98e04d489b7971925ed23e503b2     0        360000000 lovelace + TxOutDatumHashNone

erikd
erikd previously requested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix that commit subject line so it does not line wrap.

The subject should just give an overview and the body can contain more details. Probably also worth adding "plutus:" to the start of the subject line just ti make it obvious that this is all that is affected.

Jimbo4350
Jimbo4350 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@newhoggy newhoggy force-pushed the make-it-possible-to-choose-socket-file branch from 13efbb0 to 17cce6e Compare June 23, 2021 09:05
@newhoggy
Make it possible to pass configuration to plutus test script.
9ccbfa9 
Such configuration will make it possible to run the script from automated tests in CI.
@newhoggy newhoggy force-pushed the make-it-possible-to-choose-socket-file branch from 17cce6e to 9ccbfa9 Compare June 23, 2021 12:13
@newhoggy newhoggy requested a review from erikd June 23, 2021 12:14
@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 23, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 4383012 into master Jun 23, 2021
@iohk-bors iohk-bors bot deleted the make-it-possible-to-choose-socket-file branch June 23, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhoggy @erikd @Jimbo4350