Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-2907: add locli #2865

Merged
merged 4 commits into from
Jun 29, 2021
Merged

CAD-2907: add locli #2865

merged 4 commits into from
Jun 29, 2021

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Jun 24, 2021 •
edited
Loading

This adds the locli log analysis tool to nix/workbench, and integrates it.

@deepfire deepfire force-pushed the cad-2907-locli branch 7 times, most recently from deb5763 to 9e566ac Compare June 26, 2021 07:10
@deepfire
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 29, 2021
@iohk-bors @deepfire
Merge #2865
3278fec 
2865: CAD-2907: add locli r=deepfire a=deepfire

This adds the `locli` log analysis tool to `nix/workbench`, and integrates it.

Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
@Jimbo4350
Copy link
Contributor

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 29, 2021

Canceled.

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Jun 29, 2021 •
edited
Loading

Sorry @deepfire , can you change the name space? Cardano. -> Nix.Cardano. or Locli.Cardano or something similar? Happy to approve after.

Jimbo4350
Jimbo4350 requested changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple name space change

@Jimbo4350 Jimbo4350 self-requested a review June 29, 2021 15:48
@deepfire
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 29, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit c068afc into master Jun 29, 2021
@iohk-bors iohk-bors bot deleted the cad-2907-locli branch June 29, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepfire @Jimbo4350 @newhoggy