Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment about IPv4/IPv6 connectivity #2870

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Add comment about IPv4/IPv6 connectivity #2870

merged 1 commit into from
Jul 15, 2021

Conversation

weebl2000
Copy link

Since #2773 was rejected.

@weebl2000
Copy link
Author

image

As an addition to this, explicitly state the behaviour for the host address parameters.

@weebl2000
Copy link
Author

@coot @dcoutts Small addition to documentation explicitly stating IPv4/IPv6 connectivity behaviour. This might save people some time.

coot
coot requested changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution; a suggestion with a different phrasing is given.

doc/stake-pool-operations/getConfigFiles_AND_Connect.md Outdated Show resolved Hide resolved
coot
coot approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot
Copy link
Contributor

coot commented Jul 14, 2021

bors merge

iohk-bors bot added a commit that referenced this pull request Jul 14, 2021
@iohk-bors @weebl2000
Merge #2870
6d99700 
2870: Add comment about IPv4/IPv6 connectivity r=coot a=weebl2000

Since #2773 was rejected.

Co-authored-by: Wessel Nieboer <wessel.nieboer@onior.com>
Co-authored-by: Wessel <wessel@weebl.me>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 14, 2021

Build failed:

@weebl2000
Copy link
Author

@coot Do I have to fix anything or is the CI broken?

@coot
Copy link
Contributor

coot commented Jul 15, 2021

let's retry, but could you first squash all the commits.

@weebl2000 weebl2000 force-pushed the note-about-ipv4v6-connectivity branch from 3ba9abc to 7ae8f5e Compare July 15, 2021 08:23
@weebl2000
Copy link
Author

let's retry, but could you first squash all the commits.

Squashed.

@coot
Copy link
Contributor

coot commented Jul 15, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 15, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit c663184 into IntersectMBO:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weebl2000 @coot