Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors in cli output #3023

Merged
merged 5 commits into from
Aug 17, 2021
Merged

Colors in cli output #3023

merged 5 commits into from
Aug 17, 2021

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 5, 2021

No description provided.

@newhoggy newhoggy force-pushed the colors-in-cli-output branch 3 times, most recently from 289896f to fbc576b Compare August 5, 2021 11:15
@newhoggy
Copy link
Contributor Author

newhoggy commented Aug 5, 2021

Removes the following redundant parentheses:

$ cardano-cli transaction build-raw ...
Missing:  (--tx-in TX-IN )  ( )

Usage: cardano-cli transaction build-raw
            [ --byron-era
            ...

@newhoggy
Copy link
Contributor Author

newhoggy commented Aug 5, 2021

Adds a splash of colour to demonstrate that the forked version of optparse-applicative supports ANSI colours.

image

@newhoggy newhoggy force-pushed the colors-in-cli-output branch 3 times, most recently from b0641ef to b474a9d Compare August 9, 2021 03:46
@newhoggy
Copy link
Contributor Author

bors merge

iohk-bors bot added a commit that referenced this pull request Aug 16, 2021
@iohk-bors @newhoggy
Merge #3023
46573de 
3023: Colors in cli output r=newhoggy a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 16, 2021

Build failed:

@newhoggy
Copy link
Contributor Author

bors merge

iohk-bors bot added a commit that referenced this pull request Aug 16, 2021
@iohk-bors @newhoggy
Merge #3023
67d1cbb 
3023: Colors in cli output r=newhoggy a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
MarcFontaine
MarcFontaine approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@newhoggy
Copy link
Contributor Author

bors merge

iohk-bors bot added a commit that referenced this pull request Aug 16, 2021
@iohk-bors @newhoggy
Merge #3023
129873e 
3023: Colors in cli output r=newhoggy a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 16, 2021

Build failed:

@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 17, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 4829c36 into master Aug 17, 2021
@iohk-bors iohk-bors bot deleted the colors-in-cli-output branch August 17, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@MarcFontaine MarcFontaine MarcFontaine approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@deepfire deepfire Awaiting requested review from deepfire

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhoggy @erikd @MarcFontaine