Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print tx fee when using transaction build command #3032

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Print tx fee when using transaction build command #3032

merged 1 commit into from
Aug 30, 2021

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Aug 5, 2021 •
edited
Loading

Resolves #3024

dcoutts
dcoutts approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't add more detail than this. Extra detail can go into cardano-cli transaction view. The only reason this info here fits ok is because it's only here that we really know which output is the change. We should not add more misc ad-hoc things to a single command that is for building, not viewing transactions.

@Jimbo4350 Jimbo4350 force-pushed the jordan/print-tx-fee-transaction-build-cmd branch from a8108f7 to b9f147f Compare August 30, 2021 18:17
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 30, 2021
@iohk-bors @Jimbo4350
Merge #3032
1540cea 
3032: Print tx fee when using transaction build command r=Jimbo4350 a=Jimbo4350

Resolves #3024 

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 30, 2021

Canceled.

@Jimbo4350 Jimbo4350 force-pushed the jordan/print-tx-fee-transaction-build-cmd branch from f7f9dca to b9f147f Compare August 30, 2021 18:41
@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 30, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 8aaa1c9 into master Aug 30, 2021
@iohk-bors iohk-bors bot deleted the jordan/print-tx-fee-transaction-build-cmd branch August 30, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@newhoggy newhoggy newhoggy approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - return the transaction fee when executing transaction build command
3 participants
@Jimbo4350 @newhoggy @dcoutts