Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verbosity issue of TraceFetchClientState #3046

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix verbosity issue of TraceFetchClientState #3046

merged 1 commit into from
Aug 30, 2021

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Aug 9, 2021 •
edited
Loading

Resolves #2973

@Jimbo4350 Jimbo4350 force-pushed the jordan/tracefetchclientstate-logging-verbosity-fix branch from 54724a9 to 12093b7 Compare August 9, 2021 10:06
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 9, 2021
@iohk-bors @Jimbo4350
Merge #3046
a695cd8 
3046: Fix verbosity issue of TraceFetchClientState r=Jimbo4350 a=Jimbo4350

Resolves #2973 

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 13, 2021
@iohk-bors @Jimbo4350
Merge #3046
e78217c 
3046: Fix verbosity issue of TraceFetchClientState r=Jimbo4350 a=Jimbo4350

Resolves #2973 

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 13, 2021

Build failed:

karknu
karknu approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 30, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 5424a40 into master Aug 30, 2021
@iohk-bors iohk-bors bot deleted the jordan/tracefetchclientstate-logging-verbosity-fix branch August 30, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@erikd erikd erikd approved these changes

@karknu karknu karknu approved these changes

@coot coot Awaiting requested review from coot

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [1.28.0] There are byte strings in the node producer logs when "TracingVerbosity": "NormalVerbosity"
4 participants
@Jimbo4350 @newhoggy @erikd @karknu