Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD-608 trace-dispatcher library #3073

Merged
merged 12 commits into from
Oct 5, 2021
Merged

CAD-608 trace-dispatcher library #3073

merged 12 commits into from
Oct 5, 2021

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Aug 13, 2021

This is trace-dispatcher, a library for tracing, which replaces the iohk-monitoring-framework.

  • It is build completely on the base of contravariant functors
  • Every aspect of tracing is controllable via the configuration, down to every individual message
  • It has the ability to document all tracing messages
  • It can be used beside the current tracing system in a first step
  • When the old tracing infrastucture will be removed it can be dynamically reconfigured in a running node
  • It is build for efficiency from the ground up, so that messages will never be stored

Documentation is included in docs/trace-dispatcher.md

trace-resources/README.md Show resolved Hide resolved
@deepfire deepfire force-pushed the trace-dispatcher branch 3 times, most recently from bddc82d to 812dd0c Compare October 5, 2021 14:15
@deepfire
Copy link
Contributor

deepfire commented Oct 5, 2021

The stdout thread is now link-ed to the main thread, thereby propagation exceptions and shutting down the node, in case that trivial thread raises any exceptions (i.e. stdout being closed or redirected stdout write hitting a full disc).

@deepfire
Copy link
Contributor

deepfire commented Oct 5, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 5, 2021

👎 Rejected by code reviews

@deepfire deepfire dismissed coot’s stale review October 5, 2021 15:15

Marcin has already approved this.

Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks absolutely great.

Thank you a huge lot @jutaro !

@deepfire
Copy link
Contributor

deepfire commented Oct 5, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 5, 2021

👎 Rejected by code reviews

@deepfire deepfire dismissed DavidEichmann’s stale review October 5, 2021 15:16

David has also already approved it.

@deepfire
Copy link
Contributor

deepfire commented Oct 5, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 5, 2021
3073: CAD-608 trace-dispatcher library r=deepfire a=jutaro

This is `trace-dispatcher`, a library for tracing, which replaces the `iohk-monitoring-framework`.

* It is build completely on the base of contravariant functors
* Every aspect of tracing is controllable via the configuration, down to every individual message
* It has the ability to document all tracing messages
* It can be used beside the current tracing system in a first step
* When the old tracing infrastucture will be removed it can be dynamically reconfigured in a running node
* It is build for efficiency from the ground up, so that messages will never be stored

Documentation is included in docs/trace-dispatcher.md
  

Co-authored-by: Yupanqui <jnf@arcor.de>
Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 5, 2021

Canceled.

@deepfire
Copy link
Contributor

deepfire commented Oct 5, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 5, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 1f30332 into master Oct 5, 2021
@iohk-bors iohk-bors bot deleted the trace-dispatcher branch October 5, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants