Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistently use ${NETWORK_MAGIC} where possible #3148

Merged
merged 1 commit into from
Nov 3, 2021
Merged

consistently use ${NETWORK_MAGIC} where possible #3148

merged 1 commit into from
Nov 3, 2021

Conversation

savaki
Copy link
Contributor

@savaki savaki commented Aug 31, 2021

Replace hard coded 42 throughout script with ${NETWORK_MAGIC}

@savaki
consistently use ${NETWORK_MAGIC} where possible
b955497 
Replace hard coded 42 throughout script with ${NETWORK_MAGIC}
@newhoggy
Copy link
Contributor

newhoggy commented Nov 3, 2021

Thanks!

@newhoggy
Copy link
Contributor

newhoggy commented Nov 3, 2021

bors merge

iohk-bors bot added a commit that referenced this pull request Nov 3, 2021
@iohk-bors @savaki
Merge #3148
5249b97 
3148: consistently use ${NETWORK_MAGIC} where possible r=newhoggy a=savaki

Replace hard coded 42 throughout script with ${NETWORK_MAGIC}

Co-authored-by: Matt Ho <matt.ho@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 3, 2021

Timed out.

@newhoggy
Copy link
Contributor

newhoggy commented Nov 3, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 3, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit c9f261d into IntersectMBO:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savaki @newhoggy