Serialize AssetName to JSON as hex string

[cblp]

Fix (second attempt) of incorrect UTF-8 decoding of non-textual (non-UTF-8) asset names.

I also changed tx-view to test JSON repr.

BEFORE:

{
  "51f056b530aba5969bf996d1be51c7aa3581f6e0d7b9e0911a5c0c1d": {
    "TheDrifter13": 1,
    "GOLDtest": 5,
    "��\"3DUfw��������": 42 // UTF-8 fail, actually
  }
}

AFTER:

{
  "51f056b530aba5969bf996d1be51c7aa3581f6e0d7b9e0911a5c0c1d": {
    "546865447269667465723133": 1,
    "474f4c4474657374": 5,
    "00112233445566778899AABBCCDDEEFF": 42
  }
}

This is how it already looks like in UI (Cardano Explorer):

asset1...
Ticker:
Name:
Description:
Policy ID: 51f056b530aba5969bf996d1be51c7aa3581f6e0d7b9e0911a5c0c1d
Asset Name: 474f4c4474657374

Future Daedalus:

Name: GoodCoin
Asset name: 676f6f64636f696e (ASCII: goodcoin)

[gitmachtl]

Just as a note: It should also be than <policyID>.<assetName> hexstring for the normal query utxo output too, also for the tx-out and mint parameters for CLI. like the "subject" parameter for the metadata-registry, same format for all.

[cblp]

Removed textual AssetName everywhere, hex only

[gitmachtl]

Removed textual AssetName everywhere, hex only

minted and sent some tokens with bytearrays, looking good

[Jimbo4350]

Nice, a few comments

[gitmachtl]

@cblp any updates here from your side? would be nice to see this in 1.31.0 😄

[gitmachtl]

how does the output of "Friendly output multi-asset with ASCII version where possible" look like? i would leave it up to the software behind the CLI to decide to show it as readable or as hex/binary. makes it more complicated to post-process if the output is not hex all the time.

[cblp]

how does the output of "Friendly output multi-asset with ASCII version where possible" look like?

Here is an example:

mint:
  policy 52dc3d43b6d2465e96109ce75ab61abe5e9c1d8a3c9ce6ff8a3af528:
    asset 736b79 (sky): 142

i would leave it up to the software behind the CLI to decide to show it as readable or as hex/binary. makes it more complicated to post-process if the output is not hex all the time.

cardano-cli transaction view is an end-user software that uses Cardano API.

API version of cardano-cli is to be built in #3213

[gitmachtl]

ah, so the normal utxo query is not affected by this, only in the transaction view output?

[cblp]

@gitmachtl utxo query is affected only in part of switching from text to hex.

[gitmachtl]

@gitmachtl utxo query is affected only in part of switching from text to hex.

thats perfect, so hex output in the normal utxo query output, also in the JSON version of the output. and friendly names in the transaction view output.

[cblp]

@dcoutts should I fix docs (couttscoins etc.) in this PR?

[gitmachtl]

ping 😄

[Jimbo4350]

A few comments

[Jimbo4350]

Why did you make this explicit?

[cblp]

The default ToJSONKey implementation is the Value-based encoding; we need the Text-based here.

[Jimbo4350]

We now have two implementations of essentially the same thing deserialiseFromRawBytesHex and deserialiseFromRawBytesBase16. Not to mention we Base16 decode the input ByteString twice in order to get an error message in deserialiseFromRawBytesBase16. The proper solution here is to update deserialiseFromRawBytesHex to return an Either. This refactor would be better as a separate commit.

[cblp]

Too many places expect Maybe from deserialiseFromRawBytesHex. Should it be a separate PR?

[Jimbo4350]

Yeah, please raise a follow up PR to correct this. Leave a TODO in the code explaining this.

[cblp]

Here it is #3304

[Jimbo4350]

Nice 👍

[gitmachtl]

Cool! 👍

[gitmachtl]

Looking forward to see this PR within the next release.

[gitmachtl]

@JaredCorduan @newhoggy maybe someone of you is having the time to review it also?

[gitmachtl]

can we expect to see this in the next cardano-cli release?

[gitmachtl]

@nc6 do we have a chance to get this into the 1.31.0 release?

[cblp]

bors merge

[iohk-bors]

Build succeeded:

• buildkite/cardano-node
• ci/hydra-build:required

[gitmachtl]

wohoo! :-)