Restore support of Shelley 2-tuple tx body #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblp
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
Jimbo4350,
nc6 and
newhoggy
as code owners
JaredCorduan
dismissed
their stale review
I probably do not have enough context to properly review this.
dcoutts
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
More specifically, it's not just pre-Alonzo, but support for unsigned tx bodies made by the CLI during the Shelley era before we added CLI support for multi-sig scripts.
Please update the PR description. The current description confused people and made it sound like an urgent bug fix, which is far far from the reality.
Allow decode pre-Alonzo 2-tuple tx body
cblp
force-pushed
the
cblp/DecoderErrorDeserialiseFailure
branch
from
5720fb6
to
200272f
Compare
|
bors merge |
cblp
changed the title
cblp
changed the title
cblp
changed the title
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore support of 2-tuple tx body (fix #3224)