EKG counter for tips served #3300
Conversation
karknu
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
Jimbo4350,
nc6 and
newhoggy
as code owners
| let mSlotNo = case pointSlot p of | ||
| Origin -> Nothing | ||
| At slotNo -> Just slotNo | ||
|
|
There was a problem hiding this comment.
It doesn't seem necessary to transform one maybe type into another one. A few lines below we pattern match on mSlotNo, equally well we can just pattern match on pointSlot p.
| case compare maxSlotNo slotNo of | ||
| LT -> do | ||
| STM.writeTVar tMaxSlotNo slotNo | ||
| lu <- STM.modifyReadTVar' tLocalUp (+1) |
There was a problem hiding this comment.
What is modifyReadTVar'?
Is it equialvent to:
STM.modifyTVar' tLocalUP (+1) >> STM.readTVar tLocalUP
There was a problem hiding this comment.
| EQ -> do | ||
| lu <- STM.modifyReadTVar' tLocalUp (+1) | ||
| return (served, Just lu) | ||
| sendEKGDirectInt ekgDirect |
There was a problem hiding this comment.
Please add an empty line above.
| traceBlockFetchServerMetrics (Just ekgDirect) tBlocksServed tLocalUp tMaxSlotNo tracer = Tracer bsTracer | ||
|
|
||
| where | ||
| bsTracer :: TraceBlockFetchServerEvent blk -> IO () |
There was a problem hiding this comment.
This adds the local upstreaminess metric which tries to answer the question: how many times we serve a block which slot is either equal or ahead of last served block.
I would like to see a description how this related to the upstreaminess metric that is used to choose peers.
There was a problem hiding this comment.
I don't think we should mention that at all. This is a useful metric on its own, regardless of if that is how down stream peers may judge the node in the future.
karknu
force-pushed
the
karknu/tips_served
branch
from
b61da79
to
8b70830
Compare
Add an EKG counter, cardano.node.metrics.served.block.latest.coun, which can be used to track how usefull the node is to its down stream peers.
karknu
force-pushed
the
karknu/tips_served
branch
from
8b70830
to
53b9acd
Compare
|
bors r+ |
|
Build succeeded: |
|
more useful details for this new metric: |
Add an EKG counter, cardano.node.metrics.served.block.latest.count, which
can be used to track how usefull the node is to its down stream peers.
This counter can be used as follows
rate(cardano_node_metrics_served_block_latest_count_int[1h])/rate(cardano_node_metrics_blockNum_int[1h]). Which gives a value close to 0 for unpopular node. And a value around 1 or more for a very useful node.