CAD-3511: datapoint-forward library. #3303
Conversation
denisshevchenko
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
Jimbo4350,
nc6 and
newhoggy
as code owners
denisshevchenko
force-pushed
the
cad-3511-datapoint-forward-library
branch
from
c96c01d
to
a0c2127
Compare
denisshevchenko
force-pushed
the
cad-3511-datapoint-forward-library
branch
from
a0c2127
to
6ae8262
Compare
|
Please note that after it will be merged, |
denisshevchenko
force-pushed
the
cad-3511-datapoint-forward-library
branch
from
6ae8262
to
9fb279f
Compare
3337: CAD-3628: remove NodeInfo from trace-forward. r=deepfire a=denisshevchenko Since the new `datapoint-forward` library (#3303) will be used to forward structured data from the node, `NodeInfo` type should be removed from `trace-forward` library. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
3337: CAD-3628: remove NodeInfo from trace-forward. r=denisshevchenko a=denisshevchenko Since the new `datapoint-forward` library (#3303) will be used to forward structured data from the node, `NodeInfo` type should be removed from `trace-forward` library. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
3337: CAD-3628: remove NodeInfo from trace-forward. r=denisshevchenko a=denisshevchenko Since the new `datapoint-forward` library (#3303) will be used to forward structured data from the node, `NodeInfo` type should be removed from `trace-forward` library. Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
There was a problem hiding this comment.
Could you provide a high level description how does it fit into node and the trace-forwarder library.
I provided various feedback, the most important is to not use UnversionedProtocol, but provided it's own versioning scheme which would distniguish it from all other protocols (trace-forwarder, node-to-client or even node-to-node).
|
|
||
| tests :: TestTree | ||
| tests = testGroup "DataPoint.Forward.Protocol" | ||
| [ testProperty "codec" prop_codec_DataPointForward |
There was a problem hiding this comment.
You should expand the test in this module. Please check keep-alive test suite as a template.
|
Closed because of #3342 |
The third forwarding library for the new tracing infrastructure (#2847). It allows forwarding arbitrary data that provides
ToJSONinstance. Thetrace-dispatcherwill use this library to forward different structured data to external acceptor apps (for example,cardano-tracer).For reviewers: please note that this library is based on the existing
trace-forwardlibrary, but with one important difference: there is no "infinite stream" of data when we ask for it everyNseconds. Instead, acceptor app asks for eachDataPointexplicitly, when it needs this data.