[CAD-3693] Expose events api via foldBlocks, chainSyncClientWithLedgerState, and chainSyncClientPipelinedWithLedgerState #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chainSyncClientPipelinedWithLedgerState
DavidEichmann
requested review from
dcoutts,
erikd,
JaredCorduan,
nc6 and
newhoggy
as code owners
dcoutts
reviewed
Nov 18, 2021
| @@ -222,11 +222,12 @@ foldBlocks | |||
| -> ValidationMode | |||
| -> a | |||
| -- ^ The initial accumulator state. | |||
| -> (Env -> LedgerState -> BlockInMode CardanoMode -> a -> IO a) | |||
| -> (Env -> LedgerState -> [LedgerEvent] -> BlockInMode CardanoMode -> a -> IO a) | |||
| @@ -86,21 +86,21 @@ main = do | |||
| -- | Defines the client side of the chain sync protocol. | |||
| chainSyncClient | |||
| :: ChainSyncClient | |||
| (BlockInMode CardanoMode, Either Text LedgerState) | |||
| (BlockInMode CardanoMode, Either Text (LedgerState, [LedgerEvent])) | |||
There was a problem hiding this comment.
👍
BTW, remind me what the Either Text is about.
There was a problem hiding this comment.
We might get an error when applying blocks. The error will be either a HardForkLedgerError '[...] from calling tickThenApplyLedgerResult or an hash miss-match. I think I originally just used Text here out of laziness/simplicity but am happy to use a structured error instead (I'd do that in a separate PR).
There was a problem hiding this comment.
A structured error would be great 👍
Jimbo4350
approved these changes
Nov 22, 2021
| @@ -86,21 +86,21 @@ main = do | |||
| -- | Defines the client side of the chain sync protocol. | |||
| chainSyncClient | |||
| :: ChainSyncClient | |||
| (BlockInMode CardanoMode, Either Text LedgerState) | |||
| (BlockInMode CardanoMode, Either Text (LedgerState, [LedgerEvent])) | |||
There was a problem hiding this comment.
A structured error would be great 👍
|
bors merge |
|
Build succeeded: |
DavidEichmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply exposes the
[LedgerEvent]that comes with applying blocks. This should be useful for db-sync in the future.