Restrict updating CDF counters after restart. #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karknu
force-pushed
the
karknu/cdf_start
branch
3 times, most recently
from
bf73c91
to
fae7811
Compare
karknu
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
Jimbo4350,
nc6 and
newhoggy
as code owners
|
looks good on a mainnet relay here
it is useful for alarm trigger settings to not have "wrong" low values (delayed blocks), while the node is catching up after start. before it was like this
the floating average from low (restarting) values then distorted the value for a longer period of time. |
Jimbo4350
approved these changes
Nov 26, 2021
After restart the block delayes doesn't reflect the node's network condition. This change waits until the node sees a block with a delay less than 20s. Then we collect 45 samples (about 15 minutes) until we start to provide values for the CDF counters.
karknu
force-pushed
the
karknu/cdf_start
branch
from
fae7811
to
df7cbc3
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After restart the block delayes doesn't reflect the node's network
condition. This change waits until the node sees a block with a delay
less than 20s. Then we collect 45 samples (about 15 minutes) until
we start to provide values for the CDF counters.